LibAFL_QEMU: Don't require extra_tokens. #2576
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rmalmain
approved these changes
Oct 1, 2024
| @@ -357,6 +357,8 @@ pub struct EdgeCoverageModuleBuilder<AF, PF, V> { | |||
| pub struct EdgeCoverageModule<AF, PF, V> { | |||
| variant: V, | |||
| address_filter: AF, | |||
| // we only use it in system mode at the moment. | |||
| #[cfg_attr(not(emulation_mode = "systemmode"), allow(dead_code))] | |||
There was a problem hiding this comment.
more like it doesn't make sense to have this member in usermode.
i don't think we will ever need a page filter for normal processes.
There was a problem hiding this comment.
so we should remove the entry here completely
There was a problem hiding this comment.
yes.
didn't do it yet because i think we'll have to do code duplication because of this
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes it easier to build an instance without extra_tokens.